Skip to content

Conversation

@tshepang
Copy link
Member

The check is already done in enclosing code

The check is already done in enclosing code
@rustbot
Copy link
Collaborator

rustbot commented Nov 15, 2025

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 15, 2025

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu
Copy link
Member

r? me @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 15, 2025

📌 Commit 4171268 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 15, 2025
runtest.rs: remove redundant check

The check is already done in enclosing code
bors added a commit that referenced this pull request Nov 16, 2025
Rollup of 10 pull requests

Successful merges:

 - #148416 (`vec_recycle`: implementation)
 - #148522 (Micro-optimize rustdoc search index parsing)
 - #148827 (Stabilize vec_into_raw_parts)
 - #148832 (Bump library dependencies)
 - #148836 (tweak primitive reference docs)
 - #148859 (Fix overflow-checks test for RISC-V target)
 - #148886 (Add riscv64a23-unknown-linux-gnu to build-manifest TARGETS)
 - #148956 (re-enable wasm abi test)
 - #148963 (runtest.rs: remove redundant check)
 - #148968 (Add another *ExprWithBlock* test for `try` blocks)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Nov 16, 2025
Rollup of 11 pull requests

Successful merges:

 - #148416 (`vec_recycle`: implementation)
 - #148522 (Micro-optimize rustdoc search index parsing)
 - #148827 (Stabilize vec_into_raw_parts)
 - #148832 (Bump library dependencies)
 - #148836 (tweak primitive reference docs)
 - #148859 (Fix overflow-checks test for RISC-V target)
 - #148886 (Add riscv64a23-unknown-linux-gnu to build-manifest TARGETS)
 - #148956 (re-enable wasm abi test)
 - #148963 (runtest.rs: remove redundant check)
 - #148968 (Add another *ExprWithBlock* test for `try` blocks)
 - #148984 (chore: Update annotate-snippets to 0.12.9)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 34aef3a into rust-lang:main Nov 16, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 16, 2025
rust-timer added a commit that referenced this pull request Nov 16, 2025
Rollup merge of #148963 - tshepang:patch-2, r=jieyouxu

runtest.rs: remove redundant check

The check is already done in enclosing code
@tshepang tshepang deleted the patch-2 branch November 16, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants